Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for preview URL #25

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Fix for preview URL #25

merged 4 commits into from
Apr 17, 2024

Conversation

lenaorobei
Copy link
Contributor

@lenaorobei lenaorobei commented Apr 16, 2024 •
edited
Loading

Description

The way how the Preview works was changed in the Extension Manager, now it expects an object, not just a URL.

Motivation and Context

Fix for the hook to support building a JSON object instead of a URL.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@irenelagno irenelagno self-assigned this Apr 17, 2024
@lenaorobei lenaorobei merged commit 62a346c into main Apr 17, 2024
6 checks passed
@lenaorobei lenaorobei deleted the lenaorobei-patch-3 branch April 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenelagno irenelagno irenelagno approved these changes

Assignees

@irenelagno irenelagno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenaorobei @irenelagno