Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1625 Setup dev branch with snapshot dependencies #55

Merged
merged 6 commits into from
Sep 11, 2020
Merged

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Sep 11, 2020

Description

  • Added CIF Core components to build on all branches except main. By default the master branch is used. If there exists a branch with the same name, it will be checked out instead.
  • Fixed codecov.yml and ignore coverage of all dependencies.
  • Explained branching strategy in README.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the releng Release Engineering label Sep 11, 2020
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #55 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #55   +/-   ##
=========================================
  Coverage     79.16%   79.16%           
  Complexity       13       13           
=========================================
  Files             1        1           
  Lines            24       24           
  Branches          4        4           
=========================================
  Hits             19       19           
  Misses            3        3           
  Partials          2        2           
Flag Coverage Δ Complexity Δ
#unittests 79.16% <ø> (ø) 13.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30347cc...2973824. Read the comment docs.

@herzog31 herzog31 merged commit 47d62e0 into dev Sep 11, 2020
@herzog31 herzog31 deleted the issue/CIF-1625 branch September 11, 2020 14:53
@mhaack
Copy link
Contributor

mhaack commented Sep 11, 2020

This has been verified and is already used by the #54 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releng Release Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants