-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1084 - Implement the password reset page #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A generic comment and sorry if I haven't followed precisely: is this "reset password" a "forgot password" functionality that is used when a user forgot her/his password? If yes, then we should probably not have the page under "my-account" because the user cannot login, so I think it might be misleading to have this under "my-account".
+1 to @cjelger 's comment plus additionally we should make sure if you are navigation to my-account pages/sub-pages without being logged in we should redirect to the homepage and if possible open the login form. Ideally, we should also have a dedicated login page where we would redirect to. But all this is a separate ticket. |
Maybe below |
Codecov Report
@@ Coverage Diff @@
## dev #60 +/- ##
======================================
Coverage ? 79.16%
Complexity ? 13
======================================
Files ? 1
Lines ? 24
Branches ? 4
======================================
Hits ? 19
Misses ? 3
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Description
reset-password
page at/content/venia/{language-master|us}/en/reset-password.html
.resetpassword
component.ResetPassword
React component to the React app.Types of changes
Checklist: