Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1084 - Implement the password reset page #60

Merged
merged 5 commits into from
Sep 25, 2020
Merged

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Sep 23, 2020

Description

  • Adds a new reset-password page at /content/venia/{language-master|us}/en/reset-password.html.
  • Adds a proxy component for new resetpassword component.
  • Adds new ResetPassword React component to the React app.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Copy link
Contributor

@cjelger cjelger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A generic comment and sorry if I haven't followed precisely: is this "reset password" a "forgot password" functionality that is used when a user forgot her/his password? If yes, then we should probably not have the page under "my-account" because the user cannot login, so I think it might be misleading to have this under "my-account".

@mhaack
Copy link
Contributor

mhaack commented Sep 24, 2020

+1 to @cjelger 's comment plus additionally we should make sure if you are navigation to my-account pages/sub-pages without being logged in we should redirect to the homepage and if possible open the login form. Ideally, we should also have a dedicated login page where we would redirect to. But all this is a separate ticket.

@herzog31
Copy link
Member Author

@cjelger @mhaack Magento Luma has it under the account tree. Any suggestions where the page should be?

@cjelger
Copy link
Contributor

cjelger commented Sep 24, 2020

Maybe below language-masters/en ? Also make sure the page is hidden in the navigation like the search page (with hideInNav true). I agree with Markus about the redirect.

@herzog31
Copy link
Member Author

@mhaack @cjelger I moved the reset password page to /content/venia/{language-master|us}/en/reset-password.html.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@ad58471). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #60   +/-   ##
======================================
  Coverage       ?   79.16%           
  Complexity     ?       13           
======================================
  Files          ?        1           
  Lines          ?       24           
  Branches       ?        4           
======================================
  Hits           ?       19           
  Misses         ?        3           
  Partials       ?        2           
Flag Coverage Δ Complexity Δ
#unittests 79.16% <ø> (?) 13.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...enia/core/models/commerce/MyProductTeaserImpl.java 79.16% <0.00%> (ø) 13.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad58471...287c52e. Read the comment docs.

@cjelger cjelger merged commit 5626b52 into dev Sep 25, 2020
@cjelger cjelger deleted the issue/CIF-1084-2 branch September 25, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants