Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-18761 - productcollection - addToWishlist and addToCart buttons not working #1000

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jan 12, 2024

  • install addToCart and addToWishList action for items loaded with the load more button

Description

Related Issue

SITES-18761

Motivation and Context

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

… not working

  * install addToCart and addToWishList action for items loaded with the load more button
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e37a08) 89.12% compared to head (af8a5bf) 88.61%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1000      +/-   ##
============================================
- Coverage     89.12%   88.61%   -0.52%     
  Complexity     2215     2215              
============================================
  Files           354      183     -171     
  Lines          9999     5884    -4115     
  Branches       1440      823     -617     
============================================
- Hits           8912     5214    -3698     
+ Misses          789      372     -417     
  Partials        298      298              
Flag Coverage Δ
integration 51.81% <ø> (ø)
jest ?
karma ?
unittests 87.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha LSantha merged commit c284c1e into master Jan 16, 2024
18 checks passed
@LSantha LSantha deleted the SITES-18761 branch January 16, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants