-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITES-22111 - Extend core CIF graphQL resolver with new function/API to expose Errors #1006
Conversation
…to expose Errors * added getErrors() in AbstractRetriever * provided implementation for getErrors() in existing retrievers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
============================================
- Coverage 89.13% 89.11% -0.02%
- Complexity 2215 2226 +11
============================================
Files 354 355 +1
Lines 10000 10039 +39
Branches 1440 1447 +7
============================================
+ Hits 8913 8946 +33
- Misses 789 790 +1
- Partials 298 303 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@LSantha pls also add Adi as reviewer thanks! |
@ asilaghi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…to expose Errors * added hasErrors() in AbstractRetriever * added hasErrors() and getErrors() in SearchResultSet
…to expose Errors * updated unit tests * added Javadoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it
…to expose Errors * improved error message in the Error response based on runtime exception * fixed typo
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: