Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-22111 - Extend core CIF graphQL resolver with new function/API to expose Errors #1006

Merged
merged 4 commits into from
May 27, 2024

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented May 22, 2024

  • added getErrors() in AbstractRetriever
  • provided implementation for getErrors() in existing retrievers

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…to expose Errors

 * added getErrors() in AbstractRetriever
 * provided implementation for getErrors() in existing retrievers
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 82.81250% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 89.11%. Comparing base (c2356a0) to head (75d4ab4).

Files Patch % Lines
...rch/internal/services/SearchFilterServiceImpl.java 72.41% 4 Missing and 4 partials ⚠️
.../commerce/core/search/models/SearchResultsSet.java 0.00% 1 Missing and 1 partial ⚠️
...ch/internal/services/SearchResultsServiceImpl.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1006      +/-   ##
============================================
- Coverage     89.13%   89.11%   -0.02%     
- Complexity     2215     2226      +11     
============================================
  Files           354      355       +1     
  Lines         10000    10039      +39     
  Branches       1440     1447       +7     
============================================
+ Hits           8913     8946      +33     
- Misses          789      790       +1     
- Partials        298      303       +5     
Flag Coverage Δ
integration 51.81% <48.43%> (-0.01%) ⬇️
jest 86.68% <ø> (ø)
karma 95.54% <ø> (ø)
unittests 87.37% <82.81%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha LSantha requested a review from herzog31 May 22, 2024 09:56
@bradea-adobe
Copy link

@LSantha pls also add Adi as reviewer thanks!

@bradea-adobe
Copy link

@ asilaghi

Copy link

@asilaghi asilaghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

…to expose Errors

 * added hasErrors() in AbstractRetriever
 * added hasErrors() and getErrors()  in SearchResultSet
…to expose Errors

 * updated unit tests
 * added Javadoc
@LSantha LSantha requested a review from asilaghi May 27, 2024 08:49
@LSantha LSantha marked this pull request as ready for review May 27, 2024 08:50
Copy link

@asilaghi asilaghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

…to expose Errors

 * improved error message in the Error response based on runtime exception
 * fixed typo
@LSantha LSantha merged commit f8ba743 into master May 27, 2024
19 checks passed
@LSantha LSantha deleted the SITES-22112 branch May 27, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants