Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-22111 - Extend core CIF graphQL resolver with new function/API to expose Errors #1008

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jun 6, 2024

  • added support for errors in more retrievers and components

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…to expose Errors

 * added support for errors in more retrievers and components
@bradea-adobe
Copy link

@alwinjoseph02 @asilaghi pls see

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (a4953d4) to head (0ab0ded).

Files Patch % Lines
...l/models/v1/productcarousel/ProductsRetriever.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1008   +/-   ##
=========================================
  Coverage     89.11%   89.11%           
  Complexity     2226     2226           
=========================================
  Files           355      355           
  Lines         10039    10042    +3     
  Branches       1447     1447           
=========================================
+ Hits           8946     8949    +3     
  Misses          790      790           
  Partials        303      303           
Flag Coverage Δ
integration 51.82% <40.00%> (+<0.01%) ⬆️
jest 86.68% <ø> (ø)
karma 95.54% <ø> (ø)
unittests 87.37% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alwinjoseph02 alwinjoseph02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from myside

@LSantha LSantha merged commit a2d9844 into master Jun 6, 2024
19 checks passed
@LSantha LSantha deleted the ITES-22112-2 branch June 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants