-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category URL fix - convert catergoryUid back into the actual characters #1019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1019 +/- ##
=========================================
Coverage 89.14% 89.14%
Complexity 2247 2247
=========================================
Files 355 355
Lines 10097 10097
Branches 1461 1461
=========================================
Hits 9001 9001
Misses 790 790
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e the integration test issue
resourceType = com.adobe.cq.commerce.core.components.internal.models.v1.categorylist.FeaturedCategoryListImpl.RESOURCE_TYPE) | ||
resourceType = { | ||
com.adobe.cq.commerce.core.components.internal.models.v1.categorylist.FeaturedCategoryListImpl.RESOURCE_TYPE, | ||
"core/cif/components/commerce/categorycarousel/v1/categorycarousel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alwinjoseph02, how did you come to this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LSantha : This change has been done in order to resolve the integration test issue which is happening in cloud env i.e https://app.circleci.com/pipelines/github/adobe/aem-core-cif-components/7293/workflows/59affdb4-4694-42d3-98ec-a97cd5113fee/jobs/49427.
After debugging, able to see the categorycarousel.model.json url not getting resolved properly i.e localhost:4502/content/core-components-examples/library/commerce/json/exporter/jcr:content/root/responsivegrid/categorycarousel.model.json
The above issue was happening in cloud as there was no resourceType been defined for the categorycarousel. It seems like in newer version of cloud sdk we have to define its corresponding resourceType then only the {{node.location}}.model.json url will work properly.
But please let me know if there is any other better way to resolve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alwinjoseph02 , good catch and it makes sense!
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: