Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category URL fix - convert catergoryUid back into the actual characters #1019

Merged
merged 30 commits into from
Sep 25, 2024

Conversation

Satish-Pothabathula
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (50fd2de) to head (b50f7af).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1019   +/-   ##
=========================================
  Coverage     89.14%   89.14%           
  Complexity     2247     2247           
=========================================
  Files           355      355           
  Lines         10097    10097           
  Branches       1461     1461           
=========================================
  Hits           9001     9001           
  Misses          790      790           
  Partials        306      306           
Flag Coverage Δ
integration 51.59% <0.00%> (-0.04%) ⬇️
jest 86.68% <ø> (ø)
karma 95.54% <ø> (ø)
unittests 87.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

resourceType = com.adobe.cq.commerce.core.components.internal.models.v1.categorylist.FeaturedCategoryListImpl.RESOURCE_TYPE)
resourceType = {
com.adobe.cq.commerce.core.components.internal.models.v1.categorylist.FeaturedCategoryListImpl.RESOURCE_TYPE,
"core/cif/components/commerce/categorycarousel/v1/categorycarousel"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwinjoseph02, how did you come to this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LSantha : This change has been done in order to resolve the integration test issue which is happening in cloud env i.e https://app.circleci.com/pipelines/github/adobe/aem-core-cif-components/7293/workflows/59affdb4-4694-42d3-98ec-a97cd5113fee/jobs/49427.

After debugging, able to see the categorycarousel.model.json url not getting resolved properly i.e localhost:4502/content/core-components-examples/library/commerce/json/exporter/jcr:content/root/responsivegrid/categorycarousel.model.json

The above issue was happening in cloud as there was no resourceType been defined for the categorycarousel. It seems like in newer version of cloud sdk we have to define its corresponding resourceType then only the {{node.location}}.model.json url will work properly.

But please let me know if there is any other better way to resolve it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alwinjoseph02 , good catch and it makes sense!

@LSantha LSantha merged commit 618dfc9 into master Sep 25, 2024
19 checks passed
@LSantha LSantha deleted the issues/CIF-25061 branch September 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants