Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1319 - add optional title support for featured category component #228

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

mhaack
Copy link
Contributor

@mhaack mhaack commented Mar 18, 2020

Description

Featured Category List currently has the title hardcoded as "Shop by category". To make this more flexible for the AEM Authors, we need to make it configurable and add optional title support.

Related Issue

CIF-1319

How Has This Been Tested?

manually

Screenshots (if appropriate):

Screenshot 2020-03-18 at 11 35 48

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #228 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #228   +/-   ##
=========================================
  Coverage     60.14%   60.14%           
  Complexity      541      541           
=========================================
  Files           148      148           
  Lines          4393     4393           
  Branches        746      746           
=========================================
  Hits           2642     2642           
  Misses         1660     1660           
  Partials         91       91
Flag Coverage Δ Complexity Δ
#jest 38.47% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.97% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 84.9% <ø> (ø) 541 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f03e7...c514033. Read the comment docs.

@mhaack mhaack added the enhancement New feature or request label Mar 18, 2020
@cjelger cjelger merged commit d402a9a into master Mar 18, 2020
@cjelger cjelger deleted the issues/CIF-1319 branch March 18, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants