Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1316 - Price display and client-side price fetching for grouped pr… #237

Merged
merged 4 commits into from
Mar 26, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Mar 23, 2020

…oducts

  • support client-side fetching of prices for grouped products

Limitation

The main limitation of this PR is that the string prefix Starting at added on category pages for grouped products is not yet internationalised. This is an open limitation that should be fixed in another issue.

How Has This Been Tested?

Added unit tests and also manually tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…oducts

- support client-side fetching of prices for grouped products
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #237 into master will increase coverage by 0.13%.
The diff coverage is 92.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
+ Coverage     60.39%   60.52%   +0.13%     
- Complexity      554      557       +3     
============================================
  Files           147      147              
  Lines          4398     4416      +18     
  Branches        740      740              
============================================
+ Hits           2656     2673      +17     
- Misses         1657     1658       +1     
  Partials         85       85              
Flag Coverage Δ Complexity Δ
#jest 38.45% <ø> (ø) 0.00 <ø> (ø)
#karma 94.82% <90.00%> (-0.30%) 0.00 <0.00> (ø)
#unittests 85.59% <100.00%> (+0.11%) 557.00 <4.00> (+3.00)
Impacted Files Coverage Δ Complexity Δ
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js 85.71% <71.42%> (-2.62%) 0.00 <0.00> (ø)
...omponents/internal/models/v1/common/PriceImpl.java 69.04% <100.00%> (+3.25%) 18.00 <4.00> (+2.00)
...nternal/models/v1/productlist/ProductListImpl.java 80.00% <100.00%> (+0.19%) 38.00 <0.00> (ø)
...ommerce/product/v1/product/clientlib/js/product.js 96.77% <100.00%> (+0.47%) 0.00 <0.00> (ø)
...ctlist/v1/productlist/clientlibs/js/productlist.js 93.87% <100.00%> (+0.26%) 0.00 <0.00> (ø)
...internal/models/v1/common/ProductListItemImpl.java 100.00% <0.00%> (+5.26%) 10.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bec50...f00c6d4. Read the comment docs.

@cjelger cjelger changed the title CIF-136 - Price display and client-side price fetching for grouped pr… CIF-1316 - Price display and client-side price fetching for grouped pr… Mar 23, 2020
@mhaack mhaack added the feature New feature or request label Mar 23, 2020
@dplaton dplaton merged commit b613cd9 into master Mar 26, 2020
@dplaton dplaton deleted the CIF-1316 branch March 26, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants