-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React Components] update setShippingAddressOnCart to refetch cart details #270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
============================================
- Coverage 63.20% 63.11% -0.09%
- Complexity 754 755 +1
============================================
Files 173 172 -1
Lines 5354 5366 +12
Branches 840 842 +2
============================================
+ Hits 3384 3387 +3
- Misses 1855 1862 +7
- Partials 115 117 +2
Continue to review full report at Codecov.
|
dispatch({ type: 'error', error: error.toString() }); | ||
}) | ||
.finally(() => { | ||
dispatch({ type: 'endLoading' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The beginLoading
and endLoading
events are only available via the CartContext
, so you need to use cartDispatch
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I updated the events to use cartDispatch here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dabe5651 please make sure you run tests locally first and they pass. CircleCI reports test failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me 👍
Somehow CircleCI doesn't like this fork. But I checked out the branch locally and confirmed that all tests pass. |
I checked the CI pipeline with another branch, it worked. I'll merge the PR. |
Description
Updated checkout shipping address to rerfetch cart details query now that we have address to use for taxes to fix missing tax from grand total.
Related Issue
Fixes #269.
Motivation and Context
This is required so users aren't able to checkout without taxes being applied to the cart.
How Has This Been Tested?
I tried adding an address as a guest and signed in users and saw the tax apply correctly.
Screenshots (if appropriate):
Types of changes
Checklist: