CIF-1385 - Create the Core CIF Components library pages - productcarousel component #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjelger
commented
May 13, 2020
cjelger
commented
- add proxy productcarousel component for the library
- add JSON mock response and images for the productcarousel component
- extend the css with minor changes to adapt the component to the library layout
- product images are simply stored in the DAM (see 2nd screenshot): I left all the renditions as done for the WCM components library assets
cjelger
requested review from
herzog31,
dplaton,
laurentiumagureanu,
LSantha,
mhaack and
hbacila
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=========================================
Coverage 63.20% 63.20%
Complexity 754 754
=========================================
Files 173 173
Lines 5354 5354
Branches 840 840
=========================================
Hits 3384 3384
Misses 1855 1855
Partials 115 115
Continue to review full report at Codecov.
|
# Conflicts: # examples/ui.apps/src/main/content/jcr_root/apps/cif-components-examples/clientlibs/cif-clientlib-base/.content.xml # examples/ui.apps/src/main/content/jcr_root/apps/cif-components-examples/clientlibs/venia-theme/cif-demo.css # examples/ui.content/src/main/content/jcr_root/content/core-components-examples/library/.content.xml # examples/ui.content/src/main/content/jcr_root/content/core-components-examples/library/commerce/.content.xml
…usel component - fix git merge issue
laurentiumagureanu
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.