Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1387 - Create the Core CIF Components library pages - search comp… #279

Merged
merged 2 commits into from
May 20, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented May 20, 2020

…onents

@cjelger cjelger added documentation Documentation issue To Verify labels May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #279 into master will increase coverage by 3.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
+ Coverage     60.18%   63.22%   +3.03%     
  Complexity      757      757              
============================================
  Files           164      173       +9     
  Lines          4893     5362     +469     
  Branches        843      843              
============================================
+ Hits           2945     3390     +445     
- Misses         1831     1855      +24     
  Partials        117      117              
Flag Coverage Δ Complexity Δ
#jest 40.82% <ø> (ø) 0.00 <ø> (ø)
#karma 94.88% <ø> (?) 0.00 <ø> (?)
#unittests 85.16% <100.00%> (ø) 757.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...ommerce/core/examples/servlets/GraphqlServlet.java 90.44% <100.00%> (ø) 33.00 <0.00> (ø)
...ommerce/product/v1/product/clientlib/js/product.js 96.77% <0.00%> (ø) 0.00% <0.00%> (?%)
...merce/product/v1/product/clientlib/js/addToCart.js 97.61% <0.00%> (ø) 0.00% <0.00%> (?%)
...ctteaser/v1/productteaser/clientlibs/js/actions.js 92.59% <0.00%> (ø) 0.00% <0.00%> (?%)
...product/v1/product/clientlib/js/variantSelector.js 98.30% <0.00%> (ø) 0.00% <0.00%> (?%)
...oductcollection/clientlibs/js/productcollection.js 93.87% <0.00%> (ø) 0.00% <0.00%> (?%)
...ommerce/product/v1/product/clientlib/js/gallery.js 94.87% <0.00%> (ø) 0.00% <0.00%> (?%)
...ps/core/cif/clientlibs/common/js/PriceFormatter.js 90.90% <0.00%> (ø) 0.00% <0.00%> (?%)
...vigation/v1/navigation/clientlibs/js/navigation.js 98.73% <0.00%> (ø) 0.00% <0.00%> (?%)
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js 85.48% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924d40e...018834d. Read the comment docs.

@cjelger cjelger requested a review from hbacila May 20, 2020 12:25
@hbacila hbacila merged commit 303d274 into master May 20, 2020
@hbacila hbacila deleted the CIF-1387 branch May 20, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issue To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants