Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1392 - CIF Components library pages - Add support for client-side… #292

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Jun 4, 2020

… price loading

  • modified the servlet to return the right price response depending on the parameters of the GraphQL query

… price loading

- modified the servlet to return the right response depending on the parameters of the GraphQL query
@cjelger cjelger added documentation Documentation issue To Verify labels Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #292 into master will decrease coverage by 2.82%.
The diff coverage is 96.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
- Coverage     63.62%   60.79%   -2.83%     
- Complexity      757      761       +4     
============================================
  Files           175      166       -9     
  Lines          5443     4979     -464     
  Branches        853      854       +1     
============================================
- Hits           3463     3027     -436     
+ Misses         1863     1838      -25     
+ Partials        117      114       -3     
Flag Coverage Δ Complexity Δ
#jest 42.20% <ø> (ø) 0.00 <ø> (ø)
#karma ? ?
#unittests 85.39% <96.66%> (+0.22%) 761.00 <0.00> (+4.00)
Impacted Files Coverage Δ Complexity Δ
...ommerce/core/examples/servlets/GraphqlServlet.java 93.66% <96.66%> (+3.22%) 37.00 <0.00> (+4.00)
...ps/core/cif/clientlibs/common/js/PriceFormatter.js
...ommerce/product/v1/product/clientlib/js/product.js
...merce/product/v1/product/clientlib/js/addToCart.js
...product/v1/product/clientlib/js/variantSelector.js
...ommerce/product/v1/product/clientlib/js/gallery.js
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js
...vigation/v1/navigation/clientlibs/js/navigation.js
...ctteaser/v1/productteaser/clientlibs/js/actions.js
...oductcollection/clientlibs/js/productcollection.js
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41190a2...f98c745. Read the comment docs.

@cjelger cjelger merged commit 5161cfb into master Jun 5, 2020
@cjelger cjelger deleted the CIF-1392 branch June 5, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issue To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants