CIF-1436 - Can't remove or edit items from shopping cart #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was caused by the minicart refactoring that we've done some time ago - when the first product is added to the cart the "handlers" were not initialized. I removed the "cart handler" methods and use the actions directly. The same problem affects the coupons feature - both "Add coupon" and "Remove coupon" were broken because of the same issue. The same fix has been applied to those as well.
dplaton
requested review from
mhaack,
herzog31,
LSantha,
laurentiumagureanu,
cjelger and
hbacila
herzog31
reviewed
Jun 22, 2020
| </I18nextProvider> | ||
| ); | ||
| expect(asFragment()).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('applies an coupon', () => { |
There was a problem hiding this comment.
Since we don't have E2E tests, I would like to keep the tests that make sure that clicks on "Apply coupon" calls the useCouponForm resp. "Remove coupon" calls the useCouponItem hooks.
There was a problem hiding this comment.
I was thinking of implementing some tests for the useXXX "hooks" I added, but you're right, we still need to test the wiring here.
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
============================================
+ Coverage 64.62% 64.88% +0.26%
Complexity 809 809
============================================
Files 181 184 +3
Lines 5631 5639 +8
Branches 875 875
============================================
+ Hits 3639 3659 +20
+ Misses 1864 1852 -12
Partials 128 128
Continue to review full report at Codecov.
|
herzog31
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was caused by the minicart refactoring that we've done some time ago - when the first product is added to the cart the "handlers" were not initialized. I removed the "cart handler" methods and use the actions directly.
The same problem affects the coupons feature - both "Add coupon" and "Remove coupon" were broken because of the same issue. The same fix has been applied to those as well.
Related Issue
CIF-1436
Motivation and Context
Fix the shopping cart functionality
How Has This Been Tested?
Functional testing
Screenshots (if appropriate):
Types of changes
Checklist: