CIF-1471 - Use the ValueMapDecorator from the Sling API instead of the one from the Commerce API #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2020 11:49
Replaced the references to `com.adobe.cq.commerce.common.ValueMapDecorator` with `org.apache.sling.api.wrappers.ValueMapDecorator`
* Fix formatting * Add a missing dependency to the "examples" bundle which was causing test failures
dplaton
requested review from
mhaack,
herzog31,
LSantha,
laurentiumagureanu,
cjelger and
hbacila
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 64.88% 64.88%
Complexity 809 809
=========================================
Files 184 184
Lines 5639 5639
Branches 875 875
=========================================
Hits 3659 3659
Misses 1852 1852
Partials 128 128
Continue to review full report at Codecov.
|
mhaack
approved these changes
Jun 25, 2020
herzog31
approved these changes
Jun 25, 2020
cjelger
reviewed
Jun 25, 2020
| <dependency> | ||
| <groupId>org.apache.sling</groupId> | ||
| <artifactId>org.apache.sling.api</artifactId> | ||
| <version>2.18.4</version> |
There was a problem hiding this comment.
Isn't the version inherited from the parent POM?
There was a problem hiding this comment.
This dependency is not declared in the parent POM, it's only declared in the CIF Core Components bundle
LSantha
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the references to
com.adobe.cq.commerce.common.ValueMapDecoratorwithorg.apache.sling.api.wrappers.ValueMapDecoratorRelated Issue
CIF-1471
Motivation and Context
Always prefer Sling APIs over AEM ones.
How Has This Been Tested?
Unit testing
Screenshots (if appropriate):
Types of changes
Checklist: