CIF-1529 - Include CIF Add-On in IT setup for Cloud SDK

[cjelger]

Important: the URL to download the CIF Add-On is set as a CircleCI variable CIF_ADDON_URL. This is obfuscated in the build output so nobody can have access to the add-on.

This has the main drawback that the version of the Add-On is also not visible, so we might forget to update it with each new release of the Add-On. Also because variables are also obfuscated in the CircleCI backend, it might become impossible with time to know which version we currently use.

We could hence maybe rename the variable to CIF_ADDON_URL_2020_7_7_SNAPSHOT so it would be straightforward from the name what version we use. If we release a new version of the Add-On, we would add for example the variable CIF_ADDON_URL_2020_7_28 and update the build.

The drawback here is that we'd have to also update the variable in the it-tests.js file.

Feedback or other ideas is welcome.

[codecov]

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #352   +/-   ##
=========================================
  Coverage     66.67%   66.67%           
  Complexity      852      852           
=========================================
  Files           192      192           
  Lines          5845     5845           
  Branches        912      912           
=========================================
  Hits           3897     3897           
  Misses         1822     1822           
  Partials        126      126           

Flag	Coverage Δ	Complexity Δ
#integration	66.86% <ø> (ø)	628.00 <ø> (ø)
#jest	45.70% <ø> (ø)	0.00 <ø> (ø)
#karma	93.93% <ø> (ø)	0.00 <ø> (ø)
#unittests	85.81% <ø> (ø)	821.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909e24b...661c4b1. Read the comment docs.

[mhaack]

I think we should also remove integration-test-cloudready, AEM Cloud support is only in combination with CIF add-on

[cjelger]

@mhaack I think we could keep integration-test-cloudready so that we test the components on Cloud SDK without the Add-On. In case integration-test-cloudready-with-addon fails, we'd know that the problem comes from the Add-On and not the Cloud SDK. In case both fail, we'd know the problem comes from the Cloud SDK. WDYT?

[mhaack]

Ok I'm fine with that it might help to find and delimit errors.