Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS errors when Product is not found #370

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Fix JS errors when Product is not found #370

merged 5 commits into from
Aug 14, 2020

Commits on Aug 10, 2020

  1. Fix JSON.parse error when galleryRoot is not present in DOM 

    JSON.parse() only accepts strings. When the galleryRoot was
not present we passed an object which led to a SyntaxError.
    @dhardtke
    dhardtke committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    1b2fbd3 View commit details
    Browse the repository at this point in the history

  2. Fix skuElement access when it is unpresent

    @dhardtke
    dhardtke committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    2a81c59 View commit details
    Browse the repository at this point in the history

  3. Add test for Product initialization without SKU present

    @dhardtke
    dhardtke committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    516b35e View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Merge branch 'master' into fix-json-parse-error

    @hbacila
    hbacila authored Aug 13, 2020
    Configuration menu
    Copy the full SHA
    656c2de View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Merge branch 'master' into fix-json-parse-error

    @hbacila
    hbacila authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    fde17bc View commit details
    Browse the repository at this point in the history