Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1638 - Add client-side support for staged catalog data #407

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Sep 24, 2020

  • disable client-side price loading on launches

How Has This Been Tested?

Extended unit tests.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

- disable client-side price loading on launches
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #407 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #407      +/-   ##
============================================
+ Coverage     86.05%   86.06%   +0.01%     
- Complexity      942      947       +5     
============================================
  Files           188      188              
  Lines          4882     4886       +4     
  Branches        695      696       +1     
============================================
+ Hits           4201     4205       +4     
  Misses          539      539              
  Partials        142      142              
Flag Coverage Δ Complexity Δ
#integration 67.28% <42.85%> (-0.11%) 689.00 <5.00> (+2.00) ⬇️
#jest 81.55% <ø> (ø) 0.00 <ø> (ø)
#karma 94.32% <ø> (ø) 0.00 <ø> (ø)
#unittests 86.23% <100.00%> (+0.02%) 915.00 <8.00> (+5.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...onents/internal/models/v1/product/ProductImpl.java 88.23% <100.00%> (ø) 57.00 <3.00> (+2.00)
...ls/v1/productcollection/ProductCollectionImpl.java 96.00% <100.00%> (ø) 13.00 <3.00> (+2.00)
...1/storeconfigexporter/StoreConfigExporterImpl.java 100.00% <100.00%> (ø) 5.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce7ba7...d52af8f. Read the comment docs.

- adapted storeconfigexporter to also properly work on launches
@herzog31 herzog31 added enhancement New feature or request verified and removed To Verify labels Sep 28, 2020
@herzog31 herzog31 merged commit cae2fc8 into master Sep 28, 2020
@herzog31 herzog31 deleted the CIF-1638 branch September 28, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants