CIF-1615 - CIF Addressbook component needs a readme #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplaton
requested review from
mhaack,
herzog31,
laurentiumagureanu,
cjelger and
hbacila
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=========================================
Coverage 86.27% 86.27%
Complexity 954 954
=========================================
Files 199 199
Lines 5058 5058
Branches 729 729
=========================================
Hits 4364 4364
Misses 552 552
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
herzog31
approved these changes
Oct 1, 2020
cjelger
approved these changes
Oct 1, 2020
cjelger
reviewed
Oct 1, 2020
| @@ -12,13 +12,13 @@ The MiniCart is a client-side component written in React which renders the shopp | |||
|
|
|||
| ## Implementation | |||
|
|
|||
| This AEM component only renders a container `div` for the [React component](../../../../../../../../../../../../javascript/minicart). | |||
| This AEM component only renders a container `div` for the [React component](/react-components/src/components/minicart). | |||
There was a problem hiding this comment.
Actually it's Minicart not minicart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(I messed up the previous PR by pushing some unrelated changes to the branch)
Add a README to the Address Book AEM component
Related Issue
CIF-1615
Motivation and Context
Documentation
How Has This Been Tested?
N/A
Screenshots (if appropriate):
Types of changes
Checklist: