Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1710 - Add category carousel illustration to CIF components examples library #432

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Nov 3, 2020

  • added new DAM asset for category carousel

Related Issue

CIF-1710

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

screenshot

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…amples library

 * added new DAM asset for category carousel
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #432 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #432   +/-   ##
=========================================
  Coverage     85.19%   85.19%           
  Complexity     1061     1061           
=========================================
  Files           220      220           
  Lines          5466     5466           
  Branches        788      788           
=========================================
  Hits           4657     4657           
  Misses          657      657           
  Partials        152      152           
Flag Coverage Δ Complexity Δ
integration 67.17% <ø> (ø) 768.00 <ø> (ø)
jest 79.81% <ø> (ø) 0.00 <ø> (ø)
karma 93.65% <ø> (ø) 0.00 <ø> (ø)
unittests 85.82% <ø> (ø) 1022.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439dea8...79a66af. Read the comment docs.

@laurentiumagureanu laurentiumagureanu merged commit 1a3a911 into master Nov 5, 2020
@laurentiumagureanu laurentiumagureanu deleted the CIF-1710 branch November 5, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants