Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1777 - Jacoco build issue with CIF components library and CloudManager #455

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Dec 15, 2020

This should hopefully fix a build error with CloudManager when the maven build adds the org.jacoco:jacoco-maven-plugin:prepare-agent argument on the command line.

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #455 (950b5bf) into master (099f870) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #455   +/-   ##
=========================================
  Coverage     85.66%   85.66%           
  Complexity     1108     1108           
=========================================
  Files           225      225           
  Lines          5600     5600           
  Branches        810      810           
=========================================
  Hits           4797     4797           
  Misses          649      649           
  Partials        154      154           
Flag Coverage Δ Complexity Δ
integration 65.80% <ø> (ø) 0.00 <ø> (ø)
jest 80.02% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 86.29% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099f870...950b5bf. Read the comment docs.

@cjelger cjelger changed the title Switch jacoco instrumentation from "offline" to "on-the-fly" CIF-1777 - Jacoco build issue with CIF components library and CloudManager Dec 15, 2020
@cjelger cjelger added the bug Something isn't working label Dec 15, 2020
@cjelger cjelger merged commit 13c2807 into master Dec 15, 2020
@cjelger cjelger deleted the jacoco branch December 15, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants