Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1776 - CIF components library clientlib is broken #457

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Dec 17, 2020

  • remove "prod" frontend build as "fedDev" build is now active by default
  • build "prod" version of the react components, to avoid that some dependencies are included twice
  • enable "quiet" option for storybook build to avoid filling the build with debug messages
  • add missing "npm install" (after removing the frontend build from the "prod" profile)

The problem was that the build mixed the webpack:dev build of the react components with the webpack:prod build of the ui.frontend project, and the consequence was that graphql library was included twice in the final clientlib. Setting everything to prod by default fixes the problem.

I also fixed two other issues:

  • the build was executed twice since the fedDev profile is also active by default
  • I disabled the very long debug of the storybook build

How Has This Been Tested?

Locally tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

- remove "prod" frontend build as "fedDev" build is now active by default
- build "prod" version of the react components, to avoid that some dependencies are included twice
- enable "quiet" option for storybook build to avoid filling the build with debug messages
- add missing "npm install" (after removing the frontend build from the "prod" profile)
@cjelger cjelger added the bug Something isn't working label Dec 17, 2020
@herzog31 herzog31 merged commit 8791f96 into master Jan 6, 2021
@herzog31 herzog31 deleted the CIF-1776 branch January 6, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants