Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2049 - implement UID support for button component and use URLProvider for the component #555

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

mhaack
Copy link
Contributor

@mhaack mhaack commented Apr 27, 2021

Description

Fixes the Button Component implementation which was very outdated.

  • add UID support
  • use URLProvider to generate PDP/PLP links

Related Issue

Fixes #553

CIF-2049

How Has This Been Tested?

Extended existing unit tests and added extra unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@mhaack mhaack added bug Something isn't working enhancement New feature or request labels Apr 27, 2021
@mhaack mhaack marked this pull request as draft April 27, 2021 14:33
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #555 (9e3abf9) into master (6816c9e) will decrease coverage by 0.09%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #555      +/-   ##
============================================
- Coverage     87.48%   87.38%   -0.10%     
- Complexity     1283     1289       +6     
============================================
  Files           234      235       +1     
  Lines          5999     6031      +32     
  Branches        881      888       +7     
============================================
+ Hits           5248     5270      +22     
- Misses          583      588       +5     
- Partials        168      173       +5     
Flag Coverage Δ Complexity Δ
integration 63.52% <2.50%> (-0.60%) 881.00 <1.00> (+1.00) ⬇️
jest 83.33% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 87.44% <80.00%> (-0.19%) 1257.00 <9.00> (+6.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...mponents/internal/models/v1/button/ButtonImpl.java 52.08% <70.58%> (+3.59%) 10.00 <0.00> (-1.00) ⬆️
...s/internal/models/v1/button/CategoryRetriever.java 75.00% <75.00%> (ø) 3.00 <3.00> (?)
...ts/models/retriever/AbstractCategoryRetriever.java 82.45% <93.33%> (-0.88%) 21.00 <6.00> (+4.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6816c9e...9e3abf9. Read the comment docs.

@mhaack mhaack marked this pull request as ready for review April 28, 2021 08:10
@laurentiumagureanu laurentiumagureanu merged commit 692925b into master Apr 28, 2021
@laurentiumagureanu laurentiumagureanu deleted the issues/CIF-2049 branch April 28, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button component doesn't use UrlProvider to create product and category links
3 participants