Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2032: url_path support for category pages #556

Merged
merged 17 commits into from
May 28, 2021
Merged

Conversation

laurentiumagureanu
Copy link
Collaborator

Description

Support using url_path for category pages.

Related Issue

CIF-2032

Motivation and Context

Support using url_path for category pages.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@mhaack
Copy link
Contributor

mhaack commented Apr 29, 2021

Can we also add a corresponding sample /etc/map which works with the url_path?

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #556 (1673ecd) into master (4ebf64e) will decrease coverage by 0.04%.
The diff coverage is 83.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #556      +/-   ##
============================================
- Coverage     87.50%   87.45%   -0.05%     
  Complexity     1294     1294              
============================================
  Files           235      235              
  Lines          6042     6059      +17     
  Branches        892      888       -4     
============================================
+ Hits           5287     5299      +12     
- Misses          583      587       +4     
- Partials        172      173       +1     
Flag Coverage Δ
integration 65.29% <69.64%> (+0.26%) ⬆️
jest 83.49% <ø> (ø)
karma 94.82% <ø> (ø)
unittests 87.32% <83.92%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nternal/models/v1/productlist/ProductListImpl.java 94.73% <ø> (-0.20%) ⬇️
...core/search/internal/models/SearchOptionsImpl.java 84.61% <69.23%> (-15.39%) ⬇️
...ts/models/retriever/AbstractCategoryRetriever.java 79.36% <81.25%> (-3.10%) ⬇️
...ch/internal/services/SearchResultsServiceImpl.java 97.54% <90.90%> (-0.39%) ⬇️
...rnal/models/v1/breadcrumb/BreadcrumbRetriever.java 95.71% <100.00%> (+2.47%) ⬆️
.../components/internal/services/UrlProviderImpl.java 94.17% <100.00%> (ø)
.../models/retriever/AbstractCategoriesRetriever.java 94.11% <100.00%> (+6.93%) ⬆️
...commerce/core/components/services/UrlProvider.java 100.00% <100.00%> (ø)
...ls/v1/productcollection/ProductCollectionImpl.java 100.00% <0.00%> (+3.70%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebf64e...1673ecd. Read the comment docs.

filter = new CategoryFilterInput().setUrlPath(identifierFilter);
break;
default:
throw new RuntimeException("Category identifier type is not supported");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be handled in this PR, but we should make sure that we handle exceptions like this, so that not the whole website breaks.

@LSantha LSantha added the enhancement New feature or request label May 28, 2021
@LSantha LSantha merged commit 41637fa into master May 28, 2021
@LSantha LSantha deleted the issues/CIF-2032 branch May 28, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants