-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-2032: url_path support for category pages #556
Conversation
Can we also add a corresponding sample /etc/map which works with the url_path? |
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
============================================
- Coverage 87.50% 87.45% -0.05%
Complexity 1294 1294
============================================
Files 235 235
Lines 6042 6059 +17
Branches 892 888 -4
============================================
+ Hits 5287 5299 +12
- Misses 583 587 +4
- Partials 172 173 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
filter = new CategoryFilterInput().setUrlPath(identifierFilter); | ||
break; | ||
default: | ||
throw new RuntimeException("Category identifier type is not supported"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to be handled in this PR, but we should make sure that we handle exceptions like this, so that not the whole website breaks.
Description
Support using url_path for category pages.
Related Issue
CIF-2032
Motivation and Context
Support using url_path for category pages.
How Has This Been Tested?
Unit test
Screenshots (if appropriate):
Types of changes
Checklist: