CIF-2060 - fix NPEs related to special handling for Launches #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for newly created Resources Launches do not fully support context aware configurations in all of the supported product versions. A workaround was introduced before to handle this special case in StoreConfigExporterImpl and MagentoGraphqlClient. In order to make those consumers agnostic to the implementation details of the workaround, the logic was moved to the ComponentsConfigurationAdapterFactory.
buuhuu
requested review from
dplaton,
mhaack,
herzog31,
LSantha and
laurentiumagureanu
mhaack
reviewed
May 12, 2021
| @@ -51,8 +54,7 @@ | |||
| import io.wcm.testing.mock.aem.junit.AemContext; | |||
| import io.wcm.testing.mock.aem.junit.AemContextCallback; | |||
|
|
|||
| import static org.mockito.Mockito.verify; | |||
| import static org.mockito.Mockito.when; | |||
| import static org.mockito.Mockito.*; | |||
There was a problem hiding this comment.
Minor, but lets avoid wildcard imports, especially if we only import low number of classes/methods.
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
============================================
- Coverage 87.41% 87.36% -0.06%
- Complexity 1291 1292 +1
============================================
Files 235 235
Lines 6031 6038 +7
Branches 888 890 +2
============================================
+ Hits 5272 5275 +3
- Misses 587 589 +2
- Partials 172 174 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mhaack
approved these changes
May 12, 2021
dplaton
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Launches do not support context aware configurations in all supported product version right now. Because of that a fallback logic has been introduced to fallback to the production content of a Launch when accessing context aware configurations. This logic fails when the content was newly created in the Launch and so production content does not (yet) exists, causing NPEs in various places.
Related Issue
CIF-2060
CIF-2061
How Has This Been Tested?
Types of changes
Checklist: