Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1748 - Content Fragment Commerce component #576

Merged
merged 13 commits into from
Jun 9, 2021
Merged

CIF-1748 - Content Fragment Commerce component #576

merged 13 commits into from
Jun 9, 2021

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented May 27, 2021

  • created initial implementation of commerce content fragment component
  • added unit tests and integration tests
  • added documentation
  • updated examples project

Description

Related Issue

CIF-1748

Motivation and Context

How Has This Been Tested?

Unit test, integration test, manually.

Screenshots (if appropriate):

dialog

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

LSantha added 7 commits May 27, 2021 13:56
 * created initial implementation of commerce content fragment component
 * added unit tests and integration tests
 * added documentation
 * updated examples project
 * fixed client library formatting
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #576 (93337e8) into master (379f310) will decrease coverage by 0.13%.
The diff coverage is 79.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #576      +/-   ##
============================================
- Coverage     87.38%   87.24%   -0.14%     
- Complexity     1301     1333      +32     
============================================
  Files           237      238       +1     
  Lines          6089     6219     +130     
  Branches        900      927      +27     
============================================
+ Hits           5321     5426     +105     
- Misses          588      597       +9     
- Partials        180      196      +16     
Flag Coverage Δ
integration 64.01% <35.38%> (-1.12%) ⬇️
jest 83.49% <ø> (ø)
karma 94.82% <ø> (ø)
unittests 86.93% <78.46%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...1/contentfragment/CommerceContentFragmentImpl.java 79.23% <79.23%> (ø)
...commerce/core/components/utils/SiteNavigation.java 88.40% <0.00%> (+2.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379f310...93337e8. Read the comment docs.

@LSantha LSantha added the enhancement New feature or request label May 28, 2021
LSantha added 3 commits May 28, 2021 22:07
 * added category URL path support for content fragment component
LSantha added 2 commits June 4, 2021 13:08
 * added support for displaying the model title on the component in the page editor
 * documentation fixes
@herzog31 herzog31 added feature New feature or request verified and removed enhancement New feature or request labels Jun 9, 2021
@herzog31 herzog31 merged commit b32e022 into master Jun 9, 2021
@herzog31 herzog31 deleted the CIF-1748 branch June 9, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants