-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1748 - Content Fragment Commerce component #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created initial implementation of commerce content fragment component * added unit tests and integration tests * added documentation * updated examples project
* fixed client library formatting
* fixed formatting
* fixed IT failure
* fixed IT failure
* fixed IT failure
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
============================================
- Coverage 87.38% 87.24% -0.14%
- Complexity 1301 1333 +32
============================================
Files 237 238 +1
Lines 6089 6219 +130
Branches 900 927 +27
============================================
+ Hits 5321 5426 +105
- Misses 588 597 +9
- Partials 180 196 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* added category URL path support for content fragment component
* fixing integration tests
mhaack
reviewed
Jun 4, 2021
...commerce/core/components/internal/models/v1/contentfragment/CommerceContentFragmentImpl.java
Outdated
Show resolved
Hide resolved
...commerce/core/components/internal/models/v1/contentfragment/CommerceContentFragmentImpl.java
Outdated
Show resolved
Hide resolved
...ot/apps/core/cif/components/commerce/contentfragment/v1/contentfragment/contentfragment.html
Outdated
Show resolved
Hide resolved
* addressing review feedback
* added support for displaying the model title on the component in the page editor * documentation fixes
mhaack
reviewed
Jun 7, 2021
...t/jcr_root/apps/core/cif/components/commerce/contentfragment/v1/contentfragment/.content.xml
Show resolved
Hide resolved
mhaack
approved these changes
Jun 8, 2021
herzog31
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
CIF-1748
Motivation and Context
How Has This Been Tested?
Unit test, integration test, manually.
Screenshots (if appropriate):
Types of changes
Checklist: