Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2196: add --staged modifier for product full detail #612

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Jul 7, 2021

To make styling of staged products easier this PR is adding a --staged modifier to the productFullDetail__root.

Related Issue

CIF-2192, CIF-2182

How Has This Been Tested?

Tested in the context of the cif core component examples

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #612 (1d13fc7) into master (80890e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #612   +/-   ##
=========================================
  Coverage     88.35%   88.35%           
  Complexity     1458     1458           
=========================================
  Files           268      268           
  Lines          6543     6543           
  Branches        985      985           
=========================================
  Hits           5781     5781           
  Misses          573      573           
  Partials        189      189           
Flag Coverage Δ
integration 63.88% <ø> (ø)
jest 85.34% <ø> (ø)
karma 94.83% <ø> (ø)
unittests 88.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80890e8...1d13fc7. Read the comment docs.

@LSantha LSantha added the enhancement New feature or request label Jul 14, 2021
@LSantha LSantha merged commit 6d4d2aa into master Jul 14, 2021
@LSantha LSantha deleted the issue/CIF-2196 branch July 14, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants