Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1923 - Minimal default styling for product component #621

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jul 14, 2021

Added default styling for product component.

Related Issue

CIF-1923

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

product

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * added default styling for product component
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #621 (f778c9d) into master (ae53d61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #621   +/-   ##
=========================================
  Coverage     88.46%   88.46%           
  Complexity     1480     1480           
=========================================
  Files           269      269           
  Lines          6587     6587           
  Branches        993      993           
=========================================
  Hits           5827     5827           
  Misses          571      571           
  Partials        189      189           
Flag Coverage Δ
integration 63.29% <ø> (ø)
jest 85.34% <ø> (ø)
karma 94.89% <ø> (ø)
unittests 88.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae53d61...f778c9d. Read the comment docs.

@buuhuu buuhuu added the enhancement New feature or request label Jul 16, 2021
@buuhuu buuhuu merged commit c327f15 into master Jul 16, 2021
@buuhuu buuhuu deleted the CIF-1923 branch July 16, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants