Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2183 - Do not show pricing information for null values #622

Merged
merged 9 commits into from
Jul 15, 2021

Conversation

herzog31
Copy link
Member

Description

  • Components that display product data will no longer display prices when the GraphQL response provides null values.
  • These null values have to be compliant to the GraphQL schema, for example:
 {
  "data": {
    "products": {
      "items": [
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "currency": "USD",
                "value": null
              },
              "regular_price": {
                "currency": "USD",
                "value": null
              }
            }
          }
        }
      ]
    }
  }
}

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the enhancement New feature or request label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #622 (461203d) into master (6d4d2aa) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #622   +/-   ##
=========================================
  Coverage     88.35%   88.35%           
- Complexity     1458     1463    +5     
=========================================
  Files           268      268           
  Lines          6543     6561   +18     
  Branches        985      986    +1     
=========================================
+ Hits           5781     5797   +16     
  Misses          573      573           
- Partials        189      191    +2     
Flag Coverage Δ
integration 63.74% <31.25%> (-0.15%) ⬇️
jest 85.34% <ø> (ø)
karma 94.89% <100.00%> (+0.06%) ⬆️
unittests 88.14% <75.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/internal/models/v1/common/PriceImpl.java 80.76% <75.00%> (-0.19%) ⬇️
...ommerce/product/v1/product/clientlib/js/product.js 97.14% <100.00%> (+0.17%) ⬆️
...oductcollection/clientlibs/js/productcollection.js 91.95% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4d2aa...461203d. Read the comment docs.

@buuhuu buuhuu merged commit 087eab5 into master Jul 15, 2021
@buuhuu buuhuu deleted the issue/CIF-2183 branch July 15, 2021 12:11
@buuhuu buuhuu removed the To Verify label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants