-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-2183 - Do not show pricing information for null values #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herzog31
requested review from
buuhuu,
dplaton,
mhaack,
LSantha and
laurentiumagureanu
July 14, 2021 09:38
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=========================================
Coverage 88.35% 88.35%
- Complexity 1458 1463 +5
=========================================
Files 268 268
Lines 6543 6561 +18
Branches 985 986 +1
=========================================
+ Hits 5781 5797 +16
Misses 573 573
- Partials 189 191 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
buuhuu
reviewed
Jul 14, 2021
bundles/core/src/main/java/com/adobe/cq/commerce/core/components/models/common/Price.java
Outdated
Show resolved
Hide resolved
...ontent/jcr_root/apps/core/cif/components/commerce/product/v1/product/clientlib/js/product.js
Show resolved
Hide resolved
buuhuu
reviewed
Jul 14, 2021
bundles/core/src/main/java/com/adobe/cq/commerce/core/components/models/common/Price.java
Show resolved
Hide resolved
buuhuu
approved these changes
Jul 14, 2021
mhaack
approved these changes
Jul 15, 2021
LSantha
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
null
values.How Has This Been Tested?
Types of changes
Checklist: