Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2211 - Update core WCM dependency to latest for CIF components #626

Merged
merged 10 commits into from
Jul 22, 2021

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jul 16, 2021

Updated version number to 2.17.2 and fixed test failures.

Related Issue

CIF-2211

Motivation and Context

JUnit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

LSantha added 3 commits July 16, 2021 18:27
 * increased core WCM components version to 2.17.2
 * fixed test failures
 * increased core WCM componnets version to 2.17.2
 * fixed test failures
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #626 (c75ed6f) into master (cea1987) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #626      +/-   ##
============================================
+ Coverage     88.19%   88.22%   +0.02%     
- Complexity     1573     1574       +1     
============================================
  Files           279      279              
  Lines          6922     6922              
  Branches       1035     1035              
============================================
+ Hits           6105     6107       +2     
+ Misses          613      612       -1     
+ Partials        204      203       -1     
Flag Coverage Δ
integration 59.91% <ø> (+0.17%) ⬆️
jest 85.61% <ø> (ø)
karma 89.05% <ø> (ø)
unittests 88.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/v1/categorylist/FeaturedCategoryListImpl.java 92.42% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea1987...c75ed6f. Read the comment docs.

LSantha added 2 commits July 20, 2021 10:07
 * install com.adobe.cq:core.wcm.components.examples.ui.config in test instance
@LSantha
Copy link
Collaborator Author

LSantha commented Jul 21, 2021

I've reverted the AEM image to 6.5.8 here and in the Venia PR (adobe/aem-cif-guides-venia#165).
Both are passing. We will clarify the supported AEM version separately.

@buuhuu buuhuu self-requested a review July 21, 2021 18:12
@laurentiumagureanu laurentiumagureanu merged commit a200481 into master Jul 22, 2021
@laurentiumagureanu laurentiumagureanu deleted the CIF-2211 branch July 22, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants