Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2223 - Productlist item shows placeholder image and image at the same time #631

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jul 20, 2021

Display placeholder image only if the product has no image.

Related Issue

CIF-2223

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…same time

 * display placeholder image only if the product has no image
@LSantha LSantha added the bug Something isn't working label Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #631 (0fd658b) into master (6199b65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #631   +/-   ##
=========================================
  Coverage     87.99%   87.99%           
  Complexity     1565     1565           
=========================================
  Files           280      280           
  Lines          6907     6907           
  Branches       1030     1030           
=========================================
  Hits           6078     6078           
  Misses          624      624           
  Partials        205      205           
Flag Coverage Δ
integration 59.68% <ø> (ø)
jest 85.61% <ø> (ø)
karma 89.05% <ø> (ø)
unittests 88.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6199b65...0fd658b. Read the comment docs.

@laurentiumagureanu laurentiumagureanu merged commit 1531597 into master Jul 22, 2021
@laurentiumagureanu laurentiumagureanu deleted the CIF-2223 branch July 22, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants