Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2385: fix NPE in ProductListItemImpl#generateId for placeholder data #677

Merged
merged 4 commits into from
Sep 7, 2021

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Sep 6, 2021

Description

Removing the skus from the placeholder data causes some venia integration tests to fail with this NPE.

Related Issue

CIF-2385
CIF-2334 (cause)

Motivation and Context

How Has This Been Tested?

unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu added the bug Something isn't working label Sep 6, 2021
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #677 (489016e) into master (460a61f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #677   +/-   ##
=========================================
  Coverage     88.58%   88.58%           
  Complexity     1598     1598           
=========================================
  Files           282      282           
  Lines          7129     7129           
  Branches       1046     1046           
=========================================
  Hits           6315     6315           
  Misses          618      618           
  Partials        196      196           
Flag Coverage Δ
integration 59.74% <100.00%> (ø)
jest 85.61% <ø> (ø)
karma 90.01% <ø> (ø)
unittests 89.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...internal/models/v1/common/ProductListItemImpl.java 96.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460a61f...489016e. Read the comment docs.

@herzog31 herzog31 merged commit 5e3485b into master Sep 7, 2021
@herzog31 herzog31 deleted the issue/CIF-2385 branch September 7, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants