Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2895 - Extend product retriever with hook for product filters #938

Merged
merged 6 commits into from
Jul 13, 2022

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Jul 7, 2022

Description

  • Added extendCategoryFilterWith and extendProductFilterWith to retrievers that support hooks to enable full replacement or extension of category and product query filters.
  • Added unit tests.

Requires a release of adobe/commerce-cif-magento-graphql#29 before it can be merged.

Related Issue

See adobe/commerce-cif-magento-graphql#27

How Has This Been Tested?

  • Unit tests + Venia example

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added feature New feature or request do not merge labels Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #938 (ccf15c9) into master (e1923ba) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #938      +/-   ##
============================================
+ Coverage     89.67%   89.72%   +0.04%     
- Complexity     2132     2148      +16     
============================================
  Files           346      346              
  Lines          9616     9660      +44     
  Branches       1385     1391       +6     
============================================
+ Hits           8623     8667      +44     
  Misses          712      712              
  Partials        281      281              
Flag Coverage Δ
integration 52.24% <46.66%> (-0.20%) ⬇️
jest 86.55% <ø> (ø)
karma 95.33% <ø> (ø)
unittests 88.80% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/models/v1/productcarousel/ProductsRetriever.java 94.36% <100.00%> (+0.71%) ⬆️
...s/v1/relatedproducts/RelatedProductsRetriever.java 96.42% <100.00%> (+0.35%) ⬆️
.../models/retriever/AbstractCategoriesRetriever.java 100.00% <100.00%> (ø)
...ts/models/retriever/AbstractCategoryRetriever.java 89.09% <100.00%> (+1.85%) ⬆️
...nts/models/retriever/AbstractProductRetriever.java 100.00% <100.00%> (ø)
...ts/models/retriever/AbstractProductsRetriever.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1923ba...ccf15c9. Read the comment docs.

@buuhuu buuhuu merged commit 1bc2813 into master Jul 13, 2022
@buuhuu buuhuu deleted the issue/CIF-2895 branch July 13, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants