-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-2895 - Extend product retriever with hook for product filters #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
buuhuu
reviewed
Jul 8, 2022
...in/java/com/adobe/cq/commerce/core/components/models/retriever/AbstractProductRetriever.java
Outdated
Show resolved
Hide resolved
10 tasks
buuhuu
approved these changes
Jul 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
============================================
+ Coverage 89.67% 89.72% +0.04%
- Complexity 2132 2148 +16
============================================
Files 346 346
Lines 9616 9660 +44
Branches 1385 1391 +6
============================================
+ Hits 8623 8667 +44
Misses 712 712
Partials 281 281
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LSantha
approved these changes
Jul 12, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extendCategoryFilterWith
andextendProductFilterWith
to retrievers that support hooks to enable full replacement or extension of category and product query filters.Requires a release of adobe/commerce-cif-magento-graphql#29 before it can be merged.
Related Issue
See adobe/commerce-cif-magento-graphql#27
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: