Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2537 - Make Associated Content Service public #945

Merged
merged 9 commits into from
Aug 4, 2022
Merged

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jul 25, 2022

Using Associated Content Service in commere content fragment and commerce experience fragment component.

Related Issue

CIF-2537

How Has This Been Tested?

Manually, JUnit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * using Associated Content Service in commere content fragment and commerce experience fragment component
@LSantha
Copy link
Collaborator Author

LSantha commented Jul 25, 2022

The failures are caused by the missing new add-on dependency which should be released.

@LSantha
Copy link
Collaborator Author

LSantha commented Aug 2, 2022

I'll resolve the conflicts soon ...

@buuhuu buuhuu added enhancement New feature or request verified labels Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #945 (a27ad70) into master (dc2eae4) will increase coverage by 0.07%.
The diff coverage is 98.07%.

@@             Coverage Diff              @@
##             master     #945      +/-   ##
============================================
+ Coverage     89.37%   89.45%   +0.07%     
+ Complexity     2187     2182       -5     
============================================
  Files           350      350              
  Lines          9828     9803      -25     
  Branches       1414     1410       -4     
============================================
- Hits           8784     8769      -15     
+ Misses          745      739       -6     
+ Partials        299      295       -4     
Flag Coverage Δ
integration 51.89% <44.23%> (-0.11%) ⬇️
jest 86.55% <ø> (ø)
karma 95.33% <ø> (ø)
unittests 88.09% <94.23%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...1/contentfragment/CommerceContentFragmentImpl.java 86.51% <94.44%> (+3.02%) ⬆️
...nternal/models/v1/productlist/ProductListImpl.java 89.01% <100.00%> (-0.07%) ⬇️
...ents/CommerceExperienceFragmentsRetrieverImpl.java 67.64% <100.00%> (+2.26%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@LSantha LSantha merged commit 05f7756 into master Aug 4, 2022
@LSantha LSantha deleted the CIF-2537 branch August 4, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants