-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-2537 - Make Associated Content Service public #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* using Associated Content Service in commere content fragment and commerce experience fragment component
The failures are caused by the missing new add-on dependency which should be released. |
I'll resolve the conflicts soon ... |
buuhuu
reviewed
Aug 2, 2022
...e/components/internal/services/experiencefragments/CommerceExperienceFragmentsRetriever.java
Outdated
Show resolved
Hide resolved
* use aem-cif-sdk-api dependency
* updated aem-cif-sdk-api dependency
* fixing IT failures
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
============================================
+ Coverage 89.37% 89.45% +0.07%
+ Complexity 2187 2182 -5
============================================
Files 350 350
Lines 9828 9803 -25
Branches 1414 1410 -4
============================================
- Hits 8784 8769 -15
+ Misses 745 739 -6
+ Partials 299 295 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
* fixing IT failures
* install the add-on for classic too
* install the add-on for classic too
buuhuu
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Associated Content Service in commere content fragment and commerce experience fragment component.
Related Issue
CIF-2537
How Has This Been Tested?
Manually, JUnit.
Types of changes
Checklist: