CIF-2948: parse response html in the current browsing context #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change replaces the use of DOMParser in the load more handlers of product collections with a
document.createRange().createContextualFragment
.The DOMParser previously parsed the returned html without any browsing context, hence flagged as scripting disabled. This causes all nodes in
<noscript>
tags to be parsed as dom nodes.The image v2 component on the other hand expects the content of the
<noscript>
tag to be pure text, which is the expected for javascript enabled browsers. Because of this the image v2 component was not working for product list experience fragments in combination with load more yet.Related Issue
CIF-2948
Motivation and Context
How Has This Been Tested?
Locally, existing uint tests
Screenshots (if appropriate):
Types of changes
Checklist: