Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2967 - Support product query extension in SearchResults #959

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Sep 12, 2022

Description

  • Added new public method extendProductQueryWith to SearchResults to allow customizing the product GraphQL query for searches.
  • Added new public method extendProductFilterWith to SearchResults to allow customizing the product filters in the GraphQL query.
  • Deprecated GenericProductAttributeFilterInput since this is not needed anymore.
  • Added unit tests.

How Has This Been Tested?

  • Added unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the bug Something isn't working label Sep 12, 2022
@herzog31 herzog31 marked this pull request as ready for review September 14, 2022 14:02
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #959 (c3ef479) into master (79aeddf) will decrease coverage by 0.34%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##             master     #959      +/-   ##
============================================
- Coverage     89.49%   89.14%   -0.35%     
+ Complexity     2211     2208       -3     
============================================
  Files           354      354              
  Lines          9967     9980      +13     
  Branches       1436     1437       +1     
============================================
- Hits           8920     8897      -23     
- Misses          750      787      +37     
+ Partials        297      296       -1     
Flag Coverage Δ
integration 51.84% <33.33%> (-0.38%) ⬇️
jest 86.68% <ø> (ø)
karma 95.53% <ø> (ø)
unittests 87.41% <80.95%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/services/GenericProductAttributeFilterInput.java 0.00% <ø> (-84.22%) ⬇️
...nal/models/v1/searchresults/SearchResultsImpl.java 87.17% <55.55%> (-9.60%) ⬇️
...ch/internal/services/SearchResultsServiceImpl.java 94.49% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@buuhuu buuhuu added enhancement New feature or request and removed bug Something isn't working labels Sep 27, 2022
@buuhuu buuhuu merged commit 03ff890 into master Sep 29, 2022
@buuhuu buuhuu deleted the issue/CIF-2967 branch September 29, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants