Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphql version conflict with peregrine 12 #962

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Sep 27, 2022

The graphql dependency chain cannot be satisfied with the Core CIF React Components. This is happens subscriptions-transport-ws@0.11.0 requires at least graphql@15.7.0 but the @adobe/aem-core-cif-react-components limit it to ~15.3.0.

Since adobe/aem-project-archetype#990 the new peer dependency handling became the default, so we should fix this.

Bumping the peer dependency from ~15.3.0 to ~15.7.2.

npm ERR! Found: graphql@16.6.0
npm ERR! node_modules/graphql
npm ERR!   peer graphql@">=0.11 <=16" from graphql-ws@5.11.2
npm ERR!   node_modules/graphql-ws
npm ERR!     peerOptional graphql-ws@"^5.5.5" from @apollo/client@3.5.10
npm ERR!     node_modules/@apollo/client
npm ERR!       peer @apollo/client@"^3.1.2" from @adobe/aem-core-cif-react-components@2.11.0
npm ERR!       node_modules/@adobe/aem-core-cif-react-components
npm ERR!         @adobe/aem-core-cif-react-components@"*" from the root project
npm ERR!       1 more (@magento/peregrine)
npm ERR!   peer graphql@"^15.7.2 || ^16.0.0" from subscriptions-transport-ws@0.11.0
npm ERR!   node_modules/subscriptions-transport-ws
npm ERR!     peerOptional subscriptions-transport-ws@"^0.9.0 || ^0.11.0" from @apollo/client@3.5.10
npm ERR!     node_modules/@apollo/client
npm ERR!       peer @apollo/client@"^3.1.2" from @adobe/aem-core-cif-react-components@2.11.0
npm ERR!       node_modules/@adobe/aem-core-cif-react-components
npm ERR!         @adobe/aem-core-cif-react-components@"*" from the root project
npm ERR!       1 more (@magento/peregrine)
npm ERR!   1 more (@apollo/client)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer graphql@"~15.3.0" from @adobe/aem-core-cif-react-components@2.11.0
npm ERR! node_modules/@adobe/aem-core-cif-react-components
npm ERR!   @adobe/aem-core-cif-react-components@"*" from the root project

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #962 (6822dcf) into master (03ff890) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #962   +/-   ##
=========================================
  Coverage     89.14%   89.14%           
  Complexity     2208     2208           
=========================================
  Files           354      354           
  Lines          9980     9980           
  Branches       1437     1437           
=========================================
  Hits           8897     8897           
  Misses          787      787           
  Partials        296      296           
Flag Coverage Δ
integration 51.84% <ø> (ø)
jest 86.68% <ø> (ø)
karma 95.53% <ø> (ø)
unittests 87.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@buuhuu buuhuu merged commit ba5b48b into master Sep 29, 2022
@buuhuu buuhuu deleted the fix/version-conflict-with-peregrine-12 branch September 29, 2022 12:56
@buuhuu buuhuu added the bug Something isn't working label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants