SITES-17412: Log WARN when getting duplicate id from Magento GraphQL API #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LSantha
approved these changes
Nov 29, 2023
|
@hrayrpapikyan , need to check the tests! The codecov check would usually fail for this PR because the new code doesn't have any coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log WARN when getting duplicate id from Magento GraphQL API
Description
Log WARN when getting duplicate id from Magento GraphQL API
Related Issue
https://jira.corp.adobe.com/browse/SITES-17412
Motivation and Context
There exists a way to get duplicate data from Magento GraphQL API, this possibility occurs when customers add data to their system and the indexers do not complete before data is retrieved from the system.
Do It Best was affected by this and the AEM Support Org spent weeks debugging (because it was also a very intermittent issue). Eventually, T3 deployed a custom build of the Category Feature List showcasing the GraphQL query and we discovered that the categoryIds were unique. After engaging and reviewing our findings with SITES engineering we agreed to log a ticket with Magneto Engineering which then Magento ack'd that this can occur.
The CIF should log a WARN in the logs to help inform the customer that they need to fix the data in their Magento instance so that their site is not showcasing incorrect data.
In the situation where the customer has [^components .content.doitbest.us.en.global.homepage.jcr-content.root.json] we should check that the resulting GraphQL response does not contain duplicate categoryId or else this would be an issue.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: