Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README.md experience platform connector Known Limitations #999

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

rkdmen
Copy link
Member

@rkdmen rkdmen commented Jan 3, 2024

Update Experience Platform Connector README.md Known Limitations

Description

  • add minimum required dependencies for EventCollectorContextProvider to be working.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@rkdmen rkdmen changed the title update README.md experience platform connector Known Limitations update README.md experience platform connector Known Limitations Jan 3, 2024
@rkdmen rkdmen requested a review from herzog31 January 3, 2024 19:20
@rkdmen rkdmen marked this pull request as ready for review January 3, 2024 19:20
@rkdmen rkdmen self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f13eab) 89.12% compared to head (c614d0e) 89.12%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #999   +/-   ##
=========================================
  Coverage     89.12%   89.12%           
  Complexity     2215     2215           
=========================================
  Files           354      354           
  Lines          9999     9999           
  Branches       1440     1440           
=========================================
  Hits           8912     8912           
  Misses          789      789           
  Partials        298      298           
Flag Coverage Δ
integration 51.81% <ø> (ø)
jest 86.68% <ø> (ø)
karma 95.53% <ø> (ø)
unittests 87.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@herzog31 herzog31 merged commit 6e37a08 into master Jan 4, 2024
18 checks passed
@herzog31 herzog31 deleted the MSRCH-4170/README-update-exp-platform-cntr branch January 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants