Fixing test

adobe · Oct 24, 2024 · b4149df · b4149df
1 parent 3b2cbee
commit b4149df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...content/jcr_root/apps/core/fd/components/form/text/v1/text/clientlibs/site/js/textview.js b/...content/jcr_root/apps/core/fd/components/form/text/v1/text/clientlibs/site/js/textview.js
@@ -63,6 +63,7 @@
                 if (fieldType !== 'form' && this.parentView.setFocus) {
                     this.parentView.setFocus(this.getId());
                 }
+                this.setActive();
                 this.element.scrollIntoView({ behavior: 'smooth', block: 'start' });
             }
 

diff --git a/ui.frontend/src/view/FormField.js b/ui.frontend/src/view/FormField.js
@@ -77,7 +77,8 @@ class FormField {
     setActive() {
         if (!this.isActive()) {
             this.element.setAttribute(Constants.DATA_ATTRIBUTE_ACTIVE, true);
-            if (this.parentView) {
+            // optimizing the performance to check if the activeChild is different, else this will be a redundant call
+            if (this.parentView?._model?.activeChild !== this._model) {
                 this.parentView._model.activeChild = this._model; // updating the activeChild of the model when a field is focused in view
             }
             this.active = true;