Star Rating component PR #1100
Open
Star Rating component PR #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devgurjar
reviewed
Apr 3, 2024
| @@ -0,0 +1,68 @@ | |||
| /*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ~ Copyright 2022 Adobe | |||
| @@ -0,0 +1,21 @@ | |||
| /*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ~ Copyright 2022 Adobe | |||
| ~ | |||
| @@ -0,0 +1,18 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!--~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ~ Copyright 2022 Adobe | |||
| @@ -0,0 +1,19 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!--~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ~ Copyright 2022 Adobe | |||
| @@ -0,0 +1,151 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!--~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ~ Copyright 2022 Adobe | |||
| @@ -0,0 +1,18 @@ | |||
| ############################################################################### | |||
| # Copyright 2022 Adobe | |||
| @@ -0,0 +1,75 @@ | |||
| /******************************************************************************* | |||
| * Copyright 2022 Adobe | |||
There was a problem hiding this comment.
update year in header in all files
|
Please write a test case for this component |
|
check for localization and support of tracking Feature |
barshat7
reviewed
Apr 22, 2024
| public Object[] getRatingList() { | ||
| List<String> ls = new ArrayList<>(); | ||
|
|
||
| for (int i = 0; i < starnumber; i++) { |
There was a problem hiding this comment.
Will the start rating start from '0'?
barshat7
reviewed
Apr 22, 2024
| } | ||
|
|
||
| #updateModelValue(widget, e) { | ||
| var value = undefined; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a PR for Star Rating component.