Remove aria-disabled attribute #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
FORMS-16328
branch
from
c9ceba3
to
d8b2339
Compare
rismehta
reviewed
Sep 18, 2024
| @@ -450,14 +450,15 @@ class FormFieldBase extends FormField { | |||
| * @param {Object} state - The state object. | |||
| */ | |||
| updateEnabled(enabled, state) { | |||
| const screenReaderText = window.DOMPurify ? window.DOMPurify.sanitize(state.screenReaderText, { ALLOWED_TAGS: [] }) : state.screenReaderText; | |||
There was a problem hiding this comment.
Let's move this code out of FormFieldBase.js. You don't need to remove aria-label attribute here
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1411 +/- ##
=========================================
Coverage 82.24% 82.24%
Complexity 902 902
=========================================
Files 103 103
Lines 2337 2337
Branches 317 317
=========================================
Hits 1922 1922
Misses 254 254
Partials 161 161 ☔ View full report in Codecov by Sentry. |
github-actions
bot
force-pushed
the
FORMS-16328
branch
from
b2f4d5c
to
f01871e
Compare
Accessibility Violations Found
|
github-actions
bot
force-pushed
the
FORMS-16328
branch
from
d231867
to
62ccadb
Compare
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Sep 18, 2024
| @@ -74,6 +74,17 @@ | |||
| } | |||
| } | |||
|
|
|||
| updateEnabled(enabled, state) { | |||
| if (this.widget) { | |||
| this.element.setAttribute(FormView.Constants.DATA_ATTRIBUTE_ENABLED, enabled); | |||
There was a problem hiding this comment.
This should be included in FormFieldBase.js, as it's necessary for our runtime, such as setting the disable attribute and its related data attributes. Changes specific to HTML, like aria attributes, should belong to the view layer (i.e., datepickerview.js). You’ll also need to call super.updateEnabled for other functions, essentially invoking the method from FormFieldBase.
rismehta
reviewed
Sep 18, 2024
| * @param {boolean} enabled - The enabled state. | ||
| * @param {Object} state - The state object. | ||
| */ | ||
| updateEnabled(enabled, state) { |
There was a problem hiding this comment.
You had to keep this function.
you just had to remove the following code from this,
this.widget.setAttribute(Constants.ARIA_DISABLED, true);
this.widget.removeAttribute(Constants.ARIA_DISABLED);
bcb5057
to
510f671
Compare
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
rismehta
reviewed
Sep 19, 2024
| @@ -65,6 +65,10 @@ | |||
| return this.element.querySelector(TextInput.selectors.qm); | |||
| } | |||
|
|
|||
| updateEnabled(enabled, state) { | |||
There was a problem hiding this comment.
If we are just calling super method here, we might as well delete this from here
github-actions
bot
force-pushed
the
FORMS-16328
branch
from
5150431
to
c5d690a
Compare
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
Sep 19, 2024
rismehta
pushed a commit
that referenced
this pull request
Oct 16, 2024
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: