Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev master8oct #1438

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Dev master8oct #1438

merged 9 commits into from
Oct 8, 2024

Conversation

rismehta
Copy link
Collaborator

@rismehta rismehta commented Oct 8, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

rismehta and others added 9 commits September 26, 2024 14:24
@rismehta
Removing type button from cq template (#1421)
1b4ad3b
@pavi41
Fix alignment of calendar icon vertically (#1416)
eac7ee0 
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
@rismehta
GH actions (#1428)
9ed6529 
* GH actions

* Dummy change

* dummy

* change

* Fix error

* Fix error

* fix error

* Fix error

* fix regex

* Fix code

* dummy change

* Dummy change

* Fix errors
@rismehta
test pr (#1429)
cb7ac2f 
* test pr

* Fixing exporter

* revert changes
@dmaurya929
FORMS-11475 Unable to select the secondary panels individually in Acc…
649a7d7 
…ordion, Wizard, Horizontal and Vertical Tabs (#1329)

* Unable to select the secondary panels individually in Accordion, Tabs on Top, Vertical Tabs

* revert bem class change of vertical tabs

* FORMS-11475 add tests and fix

* FORMS-11475 fix tests

* FORMS-11475 fix test

* Unable to select the secondary panels individually in Accordion, Tabs on Top, Vertical Tabs

* revert bem class change of vertical tabs

* FORMS-11475 add tests and fix

* FORMS-11475 fix tests

* FORMS-11475 fix test

* FORMS-11475 fix test

* Unable to select the secondary panels individually in Accordion, Tabs on Top, Vertical Tabs

* revert bem class change of vertical tabs

* FORMS-15150 update headers

* FORMS-11475 add test

* FORMS-11475 fix site test

---------

Co-authored-by: demaurya <demaurya@adobe.com>
@rismehta
FORMS-16351 Support for string in file attachment (#1418)
a0b4060 
* initial check in

* Adding test collateral

* FORMS-16351 Support for string in file attachment
@review @vdua
DOD(Yes)

* Adding field description for type string

* Adding test collateral

* updating field description

* Adding read attachments

* moving to released version

* @releng updating af-core
@TalmizAhmed
Adding more HTML input types to FieldType (#1425)
19da0c7 
* Added new HTML types to field types

* Adding hidden fieldtype

* updated spec version
@anshikag-adobe
Issue/forms 16264: Unique instantiation of calendar element of every …
f90346f 
…date time picker widget (#1432)

* FORMS-16264: Fixed test cases

* FORMS-16264: Remove same instantiation of datetimepicker calendar element

* FORMS-16264: Resolve conflict
@rismehta
Merge branch 'master' into devMaster8oct
3478050
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rismehta rismehta merged commit 2edd69f into master Oct 8, 2024
8 of 12 checks passed
@rismehta rismehta deleted the devMaster8oct branch October 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rismehta @adobe-bot @pavi41 @dmaurya929 @TalmizAhmed @anshikag-adobe