Fixed Date Widget position in rtl #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
FORMS-14749
branch
from
f341e74
to
899ab22
Compare
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
rismehta
reviewed
Oct 15, 2024
| @@ -606,7 +607,12 @@ if (typeof window.DatePickerWidget === 'undefined') { | |||
| this.#dp.style.left = styles.left; | |||
| const localeObj = new Intl.Locale(this.#lang); | |||
| if(localeObj?.textInfo?.direction == "rtl") { | |||
| this.#dp.style.right = styles.left; | |||
| let right = windowInnerWidth - (left + inputRect.width); // Calculate right offset | |||
| if (right + 433 > windowInnerWidth) { // 433 is the widget's width | |||
There was a problem hiding this comment.
hardcoding the widget's width might not be appropriate across different viewports. Can we calculate the widget's width based on the actual element dimensions.
rismehta
reviewed
Oct 15, 2024
| @@ -606,7 +607,12 @@ if (typeof window.DatePickerWidget === 'undefined') { | |||
| this.#dp.style.left = styles.left; | |||
| const localeObj = new Intl.Locale(this.#lang); | |||
| if(localeObj?.textInfo?.direction == "rtl") { | |||
| this.#dp.style.right = styles.left; | |||
| let right = windowInnerWidth - (left + inputRect.width); // Calculate right offset | |||
| if (right + 433 > windowInnerWidth) { // 433 is the widget's width | |||
There was a problem hiding this comment.
Instead of 433 will this.#dp.offsetWidth work ?
github-actions
bot
force-pushed
the
FORMS-14749
branch
from
bdfafde
to
44dbd8c
Compare
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1442 +/- ##
=========================================
Coverage 82.27% 82.27%
Complexity 923 923
=========================================
Files 103 103
Lines 2369 2369
Branches 321 321
=========================================
Hits 1949 1949
Misses 257 257
Partials 163 163 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Oct 16, 2024
| @@ -154,7 +154,7 @@ | |||
|
|
|||
| .cmp-adaptiveform-datepicker__calendar-icon { | |||
| position: absolute; | |||
| top: 50%; | |||
| top: 41px; | |||
There was a problem hiding this comment.
This will again cause issues with other viewport ? Have you verified other viewport manually
There was a problem hiding this comment.
Checked on different view ports and we have to give top in px only, if given in % icon moves to downside when error appears on the UI because it moves relative to the parent.
rismehta
reviewed
Oct 17, 2024
| @@ -40,6 +40,7 @@ describe("Form Runtime with Date Picker", () => { | |||
| // Year should be in Buddhist calendar year for Thai language | |||
| it("Test localisation for date picker for Persian", () => { | |||
| const [datePicker8, datePicker7FieldView] = Object.entries(formContainer._fields)[8]; | |||
| console.log(Object.entries(formContainer._fields)[8], 'form-container'); | |||
github-actions
bot
force-pushed
the
FORMS-14749
branch
from
e65d64e
to
4651121
Compare
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: