-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORMS-16911 Prefill of static text with explicit data bindings #1443
Conversation
Accessibility Violations Found
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case where a user has not selected dataRef in the dialog.
That should also be merged using name of the static text.
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1443 +/- ##
============================================
- Coverage 82.27% 82.24% -0.03%
+ Complexity 923 922 -1
============================================
Files 103 103
Lines 2369 2366 -3
Branches 321 321
============================================
- Hits 1949 1946 -3
Misses 257 257
Partials 163 163 ☔ View full report in Codecov by Sentry. |
name bindings is not supported in af-core, do we have use-case of name bindings as well ? |
@review @vdua
DOD(Yes)
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: