Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-16911 Prefill of static text with explicit data bindings #1443

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

rismehta
Copy link
Collaborator

@review @vdua
DOD(Yes)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

Copy link
Collaborator

@vdua vdua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case where a user has not selected dataRef in the dialog.
That should also be merged using name of the static text.

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (858282c) to head (da34c9e).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1443      +/-   ##
============================================
- Coverage     82.27%   82.24%   -0.03%     
+ Complexity      923      922       -1     
============================================
  Files           103      103              
  Lines          2369     2366       -3     
  Branches        321      321              
============================================
- Hits           1949     1946       -3     
  Misses          257      257              
  Partials        163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta
Copy link
Collaborator Author

Can we add a test case where a user has not selected dataRef in the dialog. That should also be merged using name of the static text.

name bindings is not supported in af-core, do we have use-case of name bindings as well ?

@rismehta rismehta merged commit 4f485ea into dev Oct 17, 2024
12 of 13 checks passed
@rismehta rismehta deleted the st12 branch October 17, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants