Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing flaky test #1450

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fixing flaky test #1450

merged 1 commit into from
Oct 18, 2024

Conversation

im-shiv
Copy link
Contributor

@im-shiv im-shiv commented Oct 17, 2024

No description provided.

@im-shiv im-shiv requested a review from rismehta October 17, 2024 12:39
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.28%. Comparing base (e6fa8bb) to head (21dfd8e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1450   +/-   ##
=========================================
  Coverage     82.28%   82.28%           
  Complexity      924      924           
=========================================
  Files           103      103           
  Lines          2371     2371           
  Branches        321      321           
=========================================
  Hits           1951     1951           
  Misses          257      257           
  Partials        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit 1f2b8df into dev Oct 18, 2024
12 checks passed
anshikag-adobe pushed a commit that referenced this pull request Oct 22, 2024
Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants