FORMS-16943: added dateToDaysSinceEpoch method #1455

arunattri26 · 2024-10-21T07:06:36Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

rismehta · 2024-10-21T07:31:32Z

ui.frontend/package-lock.json

-      "resolved": "https://registry.npmjs.org/@aemforms/af-custom-functions/-/af-custom-functions-1.0.10.tgz",
-      "integrity": "sha512-n3w9tHkJOI5ISVYAK2cCi5k/oTu3rGgByDmMIgOH1+Ry4mL9nM3cxBTKEkPF8Y8JiKF1aUHIKM+MeP6u5PiiUA=="
+      "version": "1.0.12",
+      "resolved": "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-aem-release/@aemforms/af-custom-functions/-/af-custom-functions-1.0.12.tgz",


This URL should point to npmjs

adobe-bot · 2024-10-21T09:42:24Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-10-21T09:42:24Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2024-10-21T09:42:34Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-10-21T09:42:41Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-10-21T09:43:07Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov · 2024-10-21T09:47:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (fc813fc) to head (0542b76).

Additional details and impacted files

@@            Coverage Diff            @@
##                dev    #1455   +/-   ##
=========================================
  Coverage     82.35%   82.35%           
  Complexity      928      928           
=========================================
  Files           103      103           
  Lines          2380     2380           
  Branches        323      323           
=========================================
  Hits           1960     1960           
  Misses          258      258           
  Partials        162      162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rismehta

Can you also add a test case for this use-case in this PR via visual rule editor ?

arunattri26 · 2024-10-23T05:34:12Z

Can you also add a test case for this use-case in this PR via visual rule editor ?

I will add it after it is merged. Since rule-editor would expect it to be present else the rule will fail. So we can't release rule-editor without this function being present in core-components.

rismehta · 2024-10-23T07:07:00Z

Can you also add a test case for this use-case in this PR via visual rule editor ?

I will add it after it is merged. Since rule-editor would expect it to be present else the rule will fail. So we can't release rule-editor without this function being present in core-components.

The rule editor shouldn't rely on the core component version, as it may also fail with older versions. Please include test cases in this PR and allow them to fail until the new version of the rule editor SPA is released.

adobe-bot · 2024-10-23T10:09:34Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-10-23T10:14:26Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-10-23T10:14:26Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2024-10-23T10:15:04Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-10-23T10:16:17Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-10-23T11:04:05Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-10-23T11:08:44Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-10-23T11:08:44Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2024-10-23T11:08:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-10-23T11:09:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-10-23T11:09:23Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

arunattri26 · 2024-10-23T12:04:31Z

Can you also add a test case for this use-case in this PR via visual rule editor ?

I will add it after it is merged. Since rule-editor would expect it to be present else the rule will fail. So we can't release rule-editor without this function being present in core-components.

The rule editor shouldn't rely on the core component version, as it may also fail with older versions. Please include test cases in this PR and allow them to fail until the new version of the rule editor SPA is released.

Done. I have added the tests for latest-addon and only my authoring test is failing.

adobe-bot · 2024-10-28T02:24:19Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-10-28T02:28:23Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	96	75

adobe-bot · 2024-10-28T02:28:23Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-10-28T02:28:33Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-06T06:51:33Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta · 2024-11-07T13:04:55Z

@arunattri26 One of the test case is failing, please check and fix it

arunattri26 · 2024-11-07T13:11:30Z

@arunattri26 One of the test case is failing, please check and fix it

@rismehta , I checked it is failing due to old quickstart we are using in tests which does not have the latest exp-editor. After updating the QS with latest devrelease/sites-rotary branch it will get resolved.

…idation

adobe-bot · 2024-11-18T10:47:36Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-11-18T10:52:58Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-18T10:53:22Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-18T10:55:15Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-11-18T10:55:15Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	86	96	96	75

adobe-bot · 2024-11-18T10:55:28Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-18T11:33:25Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-11-18T11:38:42Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-11-18T11:38:42Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2024-11-18T11:38:52Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-18T11:39:35Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-18T11:39:45Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-20T05:54:36Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-11-20T05:59:30Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2024-11-20T05:59:30Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-11-20T05:59:40Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-20T06:00:44Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-11-20T06:01:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

arunattri26 requested a review from rismehta October 21, 2024 07:06

rismehta reviewed Oct 21, 2024

View reviewed changes

arunattri26 requested a review from rismehta October 21, 2024 10:42

rismehta requested changes Oct 22, 2024

View reviewed changes

arunattri26 requested a review from rismehta October 23, 2024 05:35

github-actions bot force-pushed the FORMS-16943 branch from 8ca9763 to 9337288 Compare October 23, 2024 08:33

github-actions bot force-pushed the FORMS-16943 branch from f292ed6 to b115b17 Compare November 11, 2024 11:40

Arun Kumar Attri added 6 commits November 18, 2024 08:24

FORMS-16943: added dateToDaysSinceEpoch method

b935359

FORMS-16943: added dateToDaysSinceEpoch method

f4a4cdf

FORMS-16943: added authoring and runtime test for date comparison val…

49abb3a

…idation

FORMS-16943: added authoring and runtime test for date comparison val…

4417cb2

…idation

FORMS-16943: updated tests

4b6dbd0

FORMS-16943: updated tests

0e88720

github-actions bot force-pushed the FORMS-16943 branch from 3a5acf6 to 0e88720 Compare November 18, 2024 08:24

FORMS-16943: updated tests

0542b76

FORMS-16943: added dateToDaysSinceEpoch method #1455

Are you sure you want to change the base?

FORMS-16943: added dateToDaysSinceEpoch method #1455

Conversation

arunattri26 commented Oct 21, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

rismehta Oct 21, 2024 • edited Loading

Choose a reason for hiding this comment

arunattri26 Oct 21, 2024

Choose a reason for hiding this comment

adobe-bot commented Oct 21, 2024

Lighthouse scores (desktop)

adobe-bot commented Oct 21, 2024

Lighthouse scores (mobile)

adobe-bot commented Oct 21, 2024

Accessibility Violations Found

adobe-bot commented Oct 21, 2024

Accessibility Violations Found

adobe-bot commented Oct 21, 2024

Accessibility Violations Found

codecov bot commented Oct 21, 2024 • edited Loading

Codecov Report

rismehta left a comment

Choose a reason for hiding this comment

arunattri26 commented Oct 23, 2024

rismehta commented Oct 23, 2024

adobe-bot commented Oct 23, 2024

Accessibility Violations Found

adobe-bot commented Oct 23, 2024

Lighthouse scores (desktop)

adobe-bot commented Oct 23, 2024

Lighthouse scores (mobile)

adobe-bot commented Oct 23, 2024

Accessibility Violations Found

adobe-bot commented Oct 23, 2024

Accessibility Violations Found

adobe-bot commented Oct 23, 2024

Accessibility Violations Found

adobe-bot commented Oct 23, 2024

Lighthouse scores (desktop)

adobe-bot commented Oct 23, 2024

Lighthouse scores (mobile)

adobe-bot commented Oct 23, 2024

Accessibility Violations Found

adobe-bot commented Oct 23, 2024

Accessibility Violations Found

adobe-bot commented Oct 23, 2024

Accessibility Violations Found

arunattri26 commented Oct 23, 2024

adobe-bot commented Oct 28, 2024

Accessibility Violations Found

adobe-bot commented Oct 28, 2024

Lighthouse scores (mobile)

adobe-bot commented Oct 28, 2024

Lighthouse scores (desktop)

adobe-bot commented Oct 28, 2024

Accessibility Violations Found

adobe-bot commented Nov 6, 2024

Accessibility Violations Found

rismehta commented Nov 7, 2024

arunattri26 commented Nov 7, 2024

adobe-bot commented Nov 18, 2024

Accessibility Violations Found

adobe-bot commented Nov 18, 2024

Accessibility Violations Found

adobe-bot commented Nov 18, 2024

Accessibility Violations Found

adobe-bot commented Nov 18, 2024

Lighthouse scores (desktop)

adobe-bot commented Nov 18, 2024

Lighthouse scores (mobile)

adobe-bot commented Nov 18, 2024

Accessibility Violations Found

adobe-bot commented Nov 18, 2024

rismehta Oct 21, 2024 •

edited

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading