Forms-17238 Fix link component to support spaces in asset path #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
reviewed
Nov 14, 2024
| @@ -118,7 +117,7 @@ public String getAssetPathWithQueryParams() { | |||
| } | |||
| url = uriBuilder.build().toString(); | |||
| } catch (URISyntaxException e) { | |||
| logger.error("[FORMS] Link Component Failed to parse assetPath {}", url, e); | |||
| logger.warn("The [Forms] link component failed to process the asset path {}. Parameters will not be added to the URL.", url, e); | |||
There was a problem hiding this comment.
Please fix the build failures, the changes look ok to me.
github-actions
bot
force-pushed
the
FORMS-17238
branch
from
ed19c24
to
aeb3208
Compare
girotraapankaj
force-pushed
the
FORMS-17238
branch
from
aeb3208
to
476e99c
Compare
github-actions
bot
force-pushed
the
FORMS-17238
branch
from
476e99c
to
7d7206f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1478 +/- ##
============================================
- Coverage 82.35% 82.30% -0.05%
- Complexity 928 929 +1
============================================
Files 103 103
Lines 2380 2385 +5
Branches 323 323
============================================
+ Hits 1960 1963 +3
- Misses 258 260 +2
Partials 162 162 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
girotraapankaj
force-pushed
the
FORMS-17238
branch
from
7d7206f
to
a3acb31
Compare
github-actions
bot
force-pushed
the
FORMS-17238
branch
from
a3acb31
to
f5e70d7
Compare
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: