FORMS-17591 Broken style of vertical tabs and wizard in editor #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1495 +/- ##
=========================================
Coverage 82.33% 82.33%
Complexity 963 963
=========================================
Files 107 107
Lines 2485 2485
Branches 339 339
=========================================
Hits 2046 2046
Misses 264 264
Partials 175 175 ☔ View full report in Codecov by Sentry. |
nit23uec
reviewed
Dec 8, 2024
...content/jcr_root/apps/core/fd/components/form/verticaltabs/v1/verticaltabs/verticaltabs.html
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Dec 8, 2024
| .cmp-adaptiveform-wizard__previousNav{ | ||
|
|
||
| } | ||
| .cmp-adaptiveform-wizard__previousNav__hidden{ |
There was a problem hiding this comment.
Shouldn't hidden be a state modifier in BEM (--hidden) if not using data attribute. Btw, why not use the data attribute here?
There was a problem hiding this comment.
This BEM already exists, in this PR just enabling to load basic CSS ( like display: none of inactive tabs) in authoring.
Recently we did some refactoring to avoid loading runtime libraries in authoring, this was missed.
There was a problem hiding this comment.
@dmaurya929 Can we change this to modifier, this is incorrect
There was a problem hiding this comment.
Yes we can change. Wouldn't this will be backward incompatible change. Should I remove or add one more class cmp-adaptiveform-wizard__previousNav--hidden ?
nit23uec
reviewed
Dec 8, 2024
ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/wizard/v2/wizard/wizard.html
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Dec 8, 2024
ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/wizard/v1/wizard/wizard.html
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Dec 8, 2024
...ore/fd/components/form/verticaltabs/v1/verticaltabs/clientlibs/contentframe/css/tabsview.css
Show resolved
Hide resolved
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
github-actions
bot
force-pushed
the
fix-vtabs-editorstyles
branch
from
6803a9a to
a26fc7a
Compare
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: