Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Content Fragment List] Display in a specific order #698

Closed
surya057 opened this issue Aug 15, 2019 · 1 comment
Closed

[Content Fragment List] Display in a specific order #698

surya057 opened this issue Aug 15, 2019 · 1 comment
Assignees
@bpauli
Labels
enhancement New feature, or improvement to an existing feature.
Milestone
2.7.0

Comments

@surya057
Copy link
Contributor

surya057 commented Aug 15, 2019 •
edited
Loading

Bug Report

Current Behavior
When author configured content fragment list, Content fragments displayed in desc order of lastModified. Whenever the author updated the content fragments inside the content fragment list this display order will change.

Expected behavior/code
When the author updates the content fragment inside the content fragment list. Display order should not change it should remain the same.

Environment

Possible Solution
To provide a consistent display order, Have to add orderby predicate in query builder that generates content fragment in ContentFragmentListImpl.java.
@surya057 surya057 changed the title Displaying content fragment in a specific order Displaying content fragment list in a specific order Aug 15, 2019
@msagolj msagolj added the enhancement New feature, or improvement to an existing feature. label Aug 15, 2019
@bpauli bpauli self-assigned this Sep 9, 2019
@surya057 surya057 mentioned this issue Sep 11, 2019
Closed
bpauli added a commit that referenced this issue Sep 16, 2019
@bpauli
Displaying content fragment list in a specific order
9a0015e 
- add order by and sort order drop down to cfm list component
- enhance data source servlet to populate list for order by drop down
- enhance cfm list model to create additional predicate if order by and sort oder property is set
- adapt unit tests

fixes #698
@bpauli bpauli mentioned this issue Sep 16, 2019
Merged
@richardhand richardhand changed the title Displaying content fragment list in a specific order [Content Fragment List] Display in a specific order Sep 16, 2019
@richardhand richardhand added this to the 2.7.0 milestone Sep 16, 2019
bpauli added a commit that referenced this issue Sep 17, 2019
@bpauli
[Content Fragment List] Display in a specific order (#739)
d8f4dec 
* Displaying content fragment list in a specific order

- add order by and sort order drop down to cfm list component
- enhance data source servlet to populate list for order by drop down
- enhance cfm list model to create additional predicate if order by and sort oder property is set
- adapt unit tests

fixes #698
@bpauli bpauli closed this as completed in 0d45950 Sep 17, 2019
@bpauli bpauli reopened this Sep 17, 2019
@msagolj msagolj added done and removed to verify labels Sep 19, 2019
@msagolj
Copy link
Contributor

msagolj commented Sep 19, 2019

verified on master branch

@msagolj msagolj closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpauli bpauli

Labels
enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
4 participants
@bpauli @surya057 @richardhand @msagolj